Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 1071193002: Change device IDs from unsigned to signed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check for negative IDs Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/touch/touchscreen_util_unittest.cc ('k') | ui/events/devices/device_data_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index bae1131a5190aa3f6d9ed00f7552d16d11f2f576..13c0843da96941f3d443028045143907c2f68657 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -45,7 +45,7 @@
namespace {
// The device id of the test touchpad device.
-const unsigned int kTouchPadDeviceId = 1;
+const int kTouchPadDeviceId = 1;
const int kKeyboardDeviceId = 2;
const int kMasterKeyboardDeviceId = 3;
@@ -1931,7 +1931,7 @@ TEST_F(EventRewriterAshTest, TopRowKeysAreFunctionKeys) {
}
TEST_F(EventRewriterTest, TestRewrittenModifierClick) {
- std::vector<unsigned int> device_list;
+ std::vector<int> device_list;
device_list.push_back(10);
ui::TouchFactory::GetInstance()->SetPointerDeviceForTest(device_list);
@@ -1970,7 +1970,7 @@ TEST_F(EventRewriterTest, TestRewrittenModifierClick) {
TEST_F(EventRewriterTest, DontRewriteIfNotRewritten) {
// TODO(kpschoedel): pending changes for crbug.com/360377
// to |chromeos::EventRewriter::RewriteLocatedEvent()
- std::vector<unsigned int> device_list;
+ std::vector<int> device_list;
device_list.push_back(10);
device_list.push_back(11);
ui::TouchFactory::GetInstance()->SetPointerDeviceForTest(device_list);
« no previous file with comments | « ash/touch/touchscreen_util_unittest.cc ('k') | ui/events/devices/device_data_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698