Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: content/app/content_main_runner.cc

Issue 1071173002: Use command line to signal whether a child process was passed V8 snapshot files via file descriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8_ext_cast
Patch Set: Fix compile error Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/app/content_main_runner.cc
diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc
index f14c6ebff1d40ebe0b4bcc097a45968ce1e2416d..42f1865ad5064e260e403cad4c8f451ec51aa28b 100644
--- a/content/app/content_main_runner.cc
+++ b/content/app/content_main_runner.cc
@@ -700,14 +700,15 @@ class ContentMainRunnerImpl : public ContentMainRunner {
#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
#if defined(OS_POSIX) && !defined(OS_MACOSX)
#if !defined(OS_ANDROID)
- // kV8NativesDataDescriptor and kV8SnapshotDataDescriptor are shared with
- // child processes. On Android they are set in
+ // kV8NativesDataDescriptor and kV8SnapshotDataDescriptor could be shared
+ // with child processes via file descriptors. On Android they are set in
// ChildProcessService::InternalInitChildProcess, otherwise set them here.
- if (!process_type.empty() && process_type != switches::kZygoteProcess
- && process_type != "service") {
+ if (command_line.HasSwitch(switches::kV8NativesPassedByFD)) {
g_fds->Set(
kV8NativesDataDescriptor,
kV8NativesDataDescriptor + base::GlobalDescriptors::kBaseDescriptor);
+ }
+ if (command_line.HasSwitch(switches::kV8SnapshotPassedByFD)) {
g_fds->Set(
kV8SnapshotDataDescriptor,
kV8SnapshotDataDescriptor + base::GlobalDescriptors::kBaseDescriptor);
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698