[Android] Make cmdline_file argument to FlagChanger mandatory.

[Android] Make cmdline_file argument to FlagChanger mandatory.

We shouldn't be setting that file for apps with no command line file.

BUG=None
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242933

[frankf, 2013-12-17 23:26:34]

bulach is OOO, @navabi: ptal

[navabi, 2013-12-19 22:51:15]

https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
build/android/pylib/instrumentation/test_runner.py:88: self.flags = None
Is it ok that this is now None? Is there anywhere besides
build/android/pylib/uiautomator/test_runner.py that expects this to be a
FlagChanger instance?

[frankf, 2013-12-20 20:22:16]

https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
build/android/pylib/instrumentation/test_runner.py:88: self.flags = None
Yea, these are all the instances.

On 2013/12/19 22:51:17, navabi wrote:
> Is it ok that this is now None? Is there anywhere besides
> build/android/pylib/uiautomator/test_runner.py that expects this to be a
> FlagChanger instance?

[navabi, 2013-12-20 20:38:22]

On 2013/12/20 20:22:16, frankf wrote:
>
https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
> File build/android/pylib/instrumentation/test_runner.py (right):
> 
>
https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
> build/android/pylib/instrumentation/test_runner.py:88: self.flags = None
> Yea, these are all the instances.
> 
> On 2013/12/19 22:51:17, navabi wrote:
> > Is it ok that this is now None? Is there anywhere besides
> > build/android/pylib/uiautomator/test_runner.py that expects this to be a
> > FlagChanger instance?

lgtm.

[navabi1, 2013-12-20 20:38:58]

On 2013/12/20 20:38:22, navabi wrote:
> On 2013/12/20 20:22:16, frankf wrote:
> >
>
https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
> > File build/android/pylib/instrumentation/test_runner.py (right):
> > 
> >
>
https://codereview.chromium.org/107113006/diff/1/build/android/pylib/instrume...
> > build/android/pylib/instrumentation/test_runner.py:88: self.flags = None
> > Yea, these are all the instances.
> > 
> > On 2013/12/19 22:51:17, navabi wrote:
> > > Is it ok that this is now None? Is there anywhere besides
> > > build/android/pylib/uiautomator/test_runner.py that expects this to be a
> > > FlagChanger instance?
> 
> lgtm.

lgtm (chromium account)

[commit-bot: I haz the power, 2014-01-03 21:54:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/107113006/1

[commit-bot: I haz the power, 2014-01-03 22:03:23]

Change committed as 242933

[bulach, 2014-01-06 20:13:22]

late lgtm, thanks!