gin/wrappable_unittest.cc - Issue 107113005: Gin: Consolidate all the Converter<Wrappable> subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/wrappable_unittest.cc

Issue 107113005: Gin: Consolidate all the Converter<Wrappable> subclasses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unneeded friend declaration Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/wrappable_unittest.cc

diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc

index d6ec19e112bec7cb19cada24df2b4e81915a7437..28bb19a7725c8e420643c170327b4134ae755f1a 100644

--- a/gin/wrappable_unittest.cc

+++ b/gin/wrappable_unittest.cc

@@ -43,13 +43,6 @@ WrapperInfo* MyObject::GetWrapperInfo() {

return &kWrapperInfo;

}

-} // namespace

-template<>

-struct Converter<MyObject*> : public WrappableConverter<MyObject> {};

-namespace {

void RegisterTemplate(v8::Isolate* isolate) {

PerIsolateData* data = PerIsolateData::From(isolate);

DCHECK(data->GetObjectTemplate(&MyObject::kWrapperInfo).IsEmpty());