Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1071113002: Revert of Make ui/gl depend on the necessary runtime targets on Windows. (Closed)

Created:
5 years, 8 months ago by engedy
Modified:
5 years, 8 months ago
Reviewers:
brettw, jam, scottmg
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ui/gl depend on the necessary runtime targets on Windows. (patchset #3 id:40001 of https://codereview.chromium.org/1070933002/) Reason for revert: This CL introduces a typo to the GN build file, so that Windows GN builds fail. It should be possible to reland after below line is changed from appending to assignment. ERROR at //ui/gl/BUILD.gn:203:5: Undefined variable for +=. data_deps += [ ^-------- I don't have something with this name in scope now. See: http://build.chromium.org/p/chromium.win/builders/Win8%20GN Original issue's description: > Make ui/gl depend on the necessary runtime targets on Windows. > > Committed: https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53 > Cr-Commit-Position: refs/heads/master@{#324320} TBR=brettw@chromium.org,scottmg@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/be9f5401881a86655d188802c8f54e67ddc4e538 Cr-Commit-Position: refs/heads/master@{#324404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M gpu/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
engedy
Created Revert of Make ui/gl depend on the necessary runtime targets on Windows.
5 years, 8 months ago (2015-04-09 09:43:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071113002/1
5 years, 8 months ago (2015-04-09 09:43:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 09:44:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be9f5401881a86655d188802c8f54e67ddc4e538 Cr-Commit-Position: refs/heads/master@{#324404}
5 years, 8 months ago (2015-04-09 09:45:10 UTC) #4
engedy
On second thought, it is probably a better idea to define this as an empty ...
5 years, 8 months ago (2015-04-09 09:49:51 UTC) #5
engedy
5 years, 8 months ago (2015-04-09 10:49:57 UTC) #6
Message was sent while issue was closed.
Also, we could consider adding a Windows GN trybot so that these kinds of
mistakes can be caught in the future.

Powered by Google App Engine
This is Rietveld 408576698