Implement setSearchResults.

chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h

Index: chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h
diff --git a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h
index 930bf5487a13c5ecf54f099e0ec4c1fe59b4578b..9ecce12eff2a96a9508d2630974ffff5cd0aa4d5 100644
--- a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h
+++ b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h
@@ -9,6 +9,8 @@
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.h"
+#include "extensions/common/extension.h"
 #include "ui/app_list/search_provider.h"
 
 namespace app_list {
@@ -22,6 +24,9 @@ class LauncherSearchProvider : public SearchProvider {
 
   void Start(bool is_voice_query, const base::string16& query) override;
   void Stop() override;
+  void SetSearchResults(
+      const extensions::ExtensionId& extension_id,
+      std::vector<linked_ptr<LauncherSearchResult>> extension_results);

[Matt Giuca, 2015/04/10 13:29:14]

Hmm. I'm not really keen on having a vector of linked_ptrs here. linked_ptr
means the ownership isn't clear, and here the ownership is quite clear: the
results get created in Service::SetSearchResults, passed through to
SetSearchResults, then stored in the map which continues to own them.

Having said that, I've thought quite a bit about how you might do this with a
scoped type (scoped_ptr, ScopedVector, etc) and any way I think of it causes
trouble. Did you consider anything?

The problem is that std::map can't store a ScopedVector. You could try having
std::map onto a ScopedVector* and use an STLValueDeleter to clean up the
ScopedVector*s. Would that be too much of a mess?

To be clear: I'm not 100% against using linked_ptrs here, but I think it's good
to explore other options first.

[yawano, 2015/04/13 07:30:52]

Done.

 
  private:
   // Delays query for |kLauncherSearchProviderQueryDelayInMs|. This dispatches
@@ -31,6 +36,10 @@ class LauncherSearchProvider : public SearchProvider {
   // Dispatches |query| to LauncherSearchProvider service.
   void StartInternal(const base::string16& query);
 
+  // Keep search results of each extension.

[Matt Giuca, 2015/04/10 13:29:14]

s/Keep/The. (A field should be described as what it *is* not what it *does*.)

[yawano, 2015/04/13 07:30:52]

Done.

+  std::map<extensions::ExtensionId,
+           std::vector<linked_ptr<LauncherSearchResult>>> extension_results_;
+
   // A timer to delay query.
   base::OneShotTimer<LauncherSearchProvider> query_timer_;