content/renderer/media/webrtc/peer_connection_dependency_factory.cc - Issue 1071063005: Fix heap-use-after-free issue with WebAudioCapturerSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 1071063005: Fix heap-use-after-free issue with WebAudioCapturerSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add thread check to WebAudioCapturerSourcer destructor Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

index 0bf8b061a87e711bc17c7725f27da0430119829e..b3d3283518c5405684a68a63fdf6dbdc55c65bbe 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

@@ -504,7 +504,7 @@ PeerConnectionDependencyFactory::CreateWebAudioSource(

DVLOG(1) << "PeerConnectionDependencyFactory::CreateWebAudioSource()";

scoped_refptr<WebAudioCapturerSource>

- webaudio_capturer_source(new WebAudioCapturerSource());

+ webaudio_capturer_source(new WebAudioCapturerSource(*source));

MediaStreamAudioSource* source_data = new MediaStreamAudioSource();

// Use the current default capturer for the WebAudio track so that the

« no previous file with comments | « content/renderer/media/webaudio_capturer_source.cc ('k') | no next file » | no next file with comments »