Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1071063004: Make TestInternalWeakLists more robust against flags. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make TestInternalWeakLists more robust against flags. This makes some tests in test-heap.cc more robust against flags, now that top-level code can be optimized by the --always-opt flag. R=hpayer@chromium.org TEST=cctest/test-heap/TestInternalWeakLists Committed: https://crrev.com/63eeab12ebe69722a9bfbc7fa4ea893ca352d7bb Cr-Commit-Position: refs/heads/master@{#27699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 8 chunks +55 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-09 10:00:57 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-09 10:58:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071063004/1
5 years, 8 months ago (2015-04-09 11:00:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 11:01:24 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 11:01:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63eeab12ebe69722a9bfbc7fa4ea893ca352d7bb
Cr-Commit-Position: refs/heads/master@{#27699}

Powered by Google App Engine
This is Rietveld 408576698