Issue 107103005: Minor refactoring of code in TextIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107103005: Minor refactoring of code in TextIterator (Closed)

Created:
7 years ago by spartha

Modified:
7 years ago

Reviewers:
yosin_UTC9, Yuta Kitamura

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Minor refactoring of code in TextIterator This patch avoid unneccessary function calls, by using the already avaiable member variable. No new test cases are needed Change-Id: If7ac8eecc4e8fbfa0a4887deec4bc97a4826da48 BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163994

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/core/editing/TextIterator.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/107103005/1

7 years ago (2013-12-17 01:03:40 UTC) #3

Message was sent while issue was closed.

Change committed as 163994

Expand Messages | Collapse Messages