Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1071013002: Set the startup type to auto in windows setup. (Closed)

Created:
5 years, 8 months ago by weitao
Modified:
5 years, 8 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the startup type to auto in windows setup. This is safe to do because the custom action is only executed if the startup type was already auto at the beginning of the installation. BUG=472887 Committed: https://crrev.com/56cc1c6d0cee4c119d9b41a2a018703a06a5148b Cr-Commit-Position: refs/heads/master@{#324369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M remoting/host/installer/win/chromoting.wxs View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
weitao
5 years, 8 months ago (2015-04-09 00:17:44 UTC) #2
Jamie
lgtm
5 years, 8 months ago (2015-04-09 00:20:22 UTC) #4
Sergey Ulanov
lgtm
5 years, 8 months ago (2015-04-09 01:08:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071013002/1
5 years, 8 months ago (2015-04-09 03:50:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 04:20:05 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 04:20:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56cc1c6d0cee4c119d9b41a2a018703a06a5148b
Cr-Commit-Position: refs/heads/master@{#324369}

Powered by Google App Engine
This is Rietveld 408576698