Make ui/gl depend on the necessary runtime targets on Windows.

Make ui/gl depend on the necessary runtime targets on Windows.

Committed: https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53
Cr-Commit-Position: refs/heads/master@{#324320}

Committed: https://crrev.com/d7e993a0783684e4ccb06460394dda23b8600191
Cr-Commit-Position: refs/heads/master@{#324445}

[jam, 2015-04-08 20:46:32]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[scottmg, 2015-04-08 20:48:01]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-04-08 20:48:02]

lgtm, thanks

https://codereview.chromium.org/1070933002/diff/1/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/1070933002/diff/1/ui/gl/BUILD.gn#newcode203
ui/gl/BUILD.gn:203: # runtime dependencies
nit; capital R, end with .

[brettw, 2015-04-08 22:16:24]

LGTM with fix

https://codereview.chromium.org/1070933002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/1070933002/diff/20001/ui/gl/BUILD.gn#newcode204
ui/gl/BUILD.gn:204: deps += [
Runtime dependencies should be data_deps.

[jam, 2015-04-08 22:27:21]

https://codereview.chromium.org/1070933002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/1070933002/diff/20001/ui/gl/BUILD.gn#newcode204
ui/gl/BUILD.gn:204: deps += [
On 2015/04/08 22:16:23, brettw wrote:
> Runtime dependencies should be data_deps.

Done.

[jam, 2015-04-08 22:27:25]

The CQ bit was checked by jam@chromium.org

[jam, 2015-04-08 22:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1070933002/#ps40001
(title: "data_deps")

[commit-bot: I haz the power, 2015-04-08 22:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070933002/40001

[commit-bot: I haz the power, 2015-04-09 00:50:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-09 00:52:50]

Patchset 3 (id:??) landed as
https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53
Cr-Commit-Position: refs/heads/master@{#324320}

[engedy, 2015-04-09 09:43:21]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1071113002/ by engedy@chromium.org.

The reason for reverting is: This CL introduces a typo to the GN build file, so
that Windows GN builds fail.

It should be possible to reland after below line is changed from appending to
assignment. 

ERROR at //ui/gl/BUILD.gn:203:5: Undefined variable for +=.
    data_deps += [
    ^--------
I don't have something with this name in scope now.

See: http://build.chromium.org/p/chromium.win/builders/Win8%20GN.

[jam, 2015-04-09 14:36:21]

The CQ bit was checked by jam@chromium.org

[jam, 2015-04-09 14:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1070933002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2015-04-09 14:36:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070933002/80001

[commit-bot: I haz the power, 2015-04-09 15:20:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-09 15:21:55]

Patchset 5 (id:??) landed as
https://crrev.com/d7e993a0783684e4ccb06460394dda23b8600191
Cr-Commit-Position: refs/heads/master@{#324445}