Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 107093007: Add a UseCounter for Element.setAttributeNodeNS (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Add a UseCounter for Element.setAttributeNodeNS This function was also removed from DOM4, it must have been overlooked when the other UseCounters were added. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163363

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-06 20:36:24 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-06 20:37:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/107093007/20001
7 years ago (2013-12-06 20:47:09 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-06 23:27:16 UTC) #4
Message was sent while issue was closed.
Change committed as 163363

Powered by Google App Engine
This is Rietveld 408576698