Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1070923002: Fix incorrect AudioConverter setup for discrete channel layouts. (Closed)

Created:
5 years, 8 months ago by DaleCurtis
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect AudioConverter setup for discrete channel layouts. Discrete layouts will have a matching channel layout, but may have any number of channels. We were incorrectly skipping the channel mixer setup based only on layout. BUG=473688 TEST=new unittest. Committed: https://crrev.com/a46cde017f0f53a72eea9dd2f3c94e2b1336caee Cr-Commit-Position: refs/heads/master@{#324351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M media/base/audio_converter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_converter_unittest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M media/base/fake_audio_render_callback.h View 1 chunk +6 lines, -1 line 0 comments Download
M media/base/fake_audio_render_callback.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
DaleCurtis
5 years, 8 months ago (2015-04-08 20:43:16 UTC) #2
sandersd (OOO until July 31)
Well, I have no idea what a discrete channel layout is, but LGTM.
5 years, 8 months ago (2015-04-08 23:23:21 UTC) #3
DaleCurtis
It was a feature (which isn't in use currently) for OSX which allowed users with ...
5 years, 8 months ago (2015-04-09 00:08:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070923002/1
5 years, 8 months ago (2015-04-09 00:08:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 03:20:07 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 03:20:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a46cde017f0f53a72eea9dd2f3c94e2b1336caee
Cr-Commit-Position: refs/heads/master@{#324351}

Powered by Google App Engine
This is Rietveld 408576698