components/packed_ct_ev_whitelist/bit_stream_reader.h - Issue 1070903003: Optimize BitStreamReader, speed up EV Whitelist loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/packed_ct_ev_whitelist/bit_stream_reader.h

Issue 1070903003: Optimize BitStreamReader, speed up EV Whitelist loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary &0xff - forgot uint8_t is exactly 1 byte not at least 1 byte Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/packed_ct_ev_whitelist/bit_stream_reader.h

diff --git a/components/packed_ct_ev_whitelist/bit_stream_reader.h b/components/packed_ct_ev_whitelist/bit_stream_reader.h

index 45fa5f5a39d7463ad8a1f5855833240b6a2893db..5c95243a1af408fed664735d81f48d8e226efb5f 100644

--- a/components/packed_ct_ev_whitelist/bit_stream_reader.h

+++ b/components/packed_ct_ev_whitelist/bit_stream_reader.h

@@ -41,6 +41,11 @@ class BitStreamReader {

// LSB.

uint8_t ReadBit();

+ // Reads a single byte.

+ // Precondition: The stream must be byte-aligned (current_bit_ == 7) before

+ // calling this function.

+ uint8_t ReadByte();

const base::StringPiece source_;

// Index of the byte currently being read from.

« no previous file with comments | « no previous file | components/packed_ct_ev_whitelist/bit_stream_reader.cc » ('j') | no next file with comments »