Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1070903002: Updating build-webapp script to append the client id extension for app remoting apps automatically. (Closed)

Created:
5 years, 8 months ago by joedow
Modified:
5 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating build-webapp script to append the client id extension for app remoting apps automatically. BUG= Committed: https://crrev.com/42b8b67ab289361c178200853fb8cf9fb1af0948 Cr-Commit-Position: refs/heads/master@{#324322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/build-webapp.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
joedow
Updated build-webapp script to append the oauth client id extension when the base client id ...
5 years, 8 months ago (2015-04-08 18:51:54 UTC) #2
garykac
lgtm
5 years, 8 months ago (2015-04-08 20:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070903002/1
5 years, 8 months ago (2015-04-08 20:25:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070903002/1
5 years, 8 months ago (2015-04-08 21:46:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070903002/1
5 years, 8 months ago (2015-04-08 22:48:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070903002/1
5 years, 8 months ago (2015-04-08 23:07:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070903002/1
5 years, 8 months ago (2015-04-08 23:53:52 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 00:56:25 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:57:14 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42b8b67ab289361c178200853fb8cf9fb1af0948
Cr-Commit-Position: refs/heads/master@{#324322}

Powered by Google App Engine
This is Rietveld 408576698