Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1070893002: Move net/ocsp/* into net/cert_net/ (Closed)

Created:
5 years, 8 months ago by eroman
Modified:
5 years, 8 months ago
Reviewers:
davidben, mmenke, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert_fetcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move net/ocsp/* into net/cert_net/ BUG=455366 TBR=mmenke@chromium.org,gunsch@chromium.org Committed: https://crrev.com/ed744f3275f42ec1cd4d6ed71cb0a77c2a3a53c6 Cr-Commit-Position: refs/heads/master@{#324386}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Patch Set 3 : Update another build thing for ios #

Patch Set 4 : oops fix naming #

Patch Set 5 : undo header re-ordering -- seems to be breaking compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1215 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 4 chunks +7 lines, -7 lines 0 comments Download
A + net/cert_net/nss_ocsp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/cert_net/nss_ocsp.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + net/cert_net/nss_ocsp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M net/net_common.gypi View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
D net/ocsp/nss_ocsp.h View 1 chunk +0 lines, -39 lines 0 comments Download
D net/ocsp/nss_ocsp.cc View 1 chunk +0 lines, -986 lines 0 comments Download
D net/ocsp/nss_ocsp_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/test/net_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
eroman
5 years, 8 months ago (2015-04-08 18:42:45 UTC) #2
davidben
lgtm
5 years, 8 months ago (2015-04-08 22:47:20 UTC) #3
eroman
Added TBR as follows: mmenke --> io_thread.cc gunsch --> chromecast/*
5 years, 8 months ago (2015-04-08 22:59:23 UTC) #5
gunsch
rubberstam lgtm
5 years, 8 months ago (2015-04-08 23:05:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070893002/80001
5 years, 8 months ago (2015-04-09 06:32:10 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-09 06:35:59 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 06:36:57 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ed744f3275f42ec1cd4d6ed71cb0a77c2a3a53c6
Cr-Commit-Position: refs/heads/master@{#324386}

Powered by Google App Engine
This is Rietveld 408576698