Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1070863002: Add rappor::SampleString for consisntecy with domain+registry case (Closed)

Created:
5 years, 8 months ago by kojii
Modified:
5 years, 8 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add rappor::SampleString for consisntecy with domain+registry case This patch adds a function to sample a string to RAPPOR, in the same manner as rappor::SampleDomainAndRegistryFromGURL(). This makes callers look more consistent regardless whether it records a string or a domain+registry of a URL. Suggested in a review comment of this CL: https://codereview.chromium.org/1014543003/#msg48 BUG=461671, 429901 Committed: https://crrev.com/4e5674cf918801089ca56baf5f2fb1142e943e18 Cr-Commit-Position: refs/heads/master@{#324475}

Patch Set 1 #

Patch Set 2 : Rename to SampleString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M components/rappor/rappor_utils.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M components/rappor/rappor_utils.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kojii
PTAL.
5 years, 8 months ago (2015-04-08 18:03:45 UTC) #2
Steven Holte
On 2015/04/08 18:03:45, koji wrote: > PTAL. Maybe add the type param and just change ...
5 years, 8 months ago (2015-04-08 20:36:14 UTC) #3
kojii
Thank you for the quick review, renamed. PTAL.
5 years, 8 months ago (2015-04-09 01:00:55 UTC) #4
Steven Holte
lgtm
5 years, 8 months ago (2015-04-09 17:34:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070863002/20001
5 years, 8 months ago (2015-04-09 18:01:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 18:16:51 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 18:17:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e5674cf918801089ca56baf5f2fb1142e943e18
Cr-Commit-Position: refs/heads/master@{#324475}

Powered by Google App Engine
This is Rietveld 408576698