ASan: re-enable strict memcmp() checks.

build/sanitizers/sanitizer_options.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the default options for various compiler-based dynamic
 // tools.
 
 #include "build/build_config.h"
 
 #if defined(ADDRESS_SANITIZER) && defined(OS_MACOSX)
@@ skipping 18 matching lines @@
   extern "C"                              \
   __attribute__((no_sanitize_address))    \
   __attribute__((no_sanitize_memory))     \
   __attribute__((no_sanitize_thread))     \
   __attribute__((visibility("default")))  \
   __attribute__((used))
 #endif
 
 #if defined(ADDRESS_SANITIZER)
 // Default options for AddressSanitizer in various configurations:
-//   strict_memcmp=1 - disable the strict memcmp() checking
-//     (http://crbug.com/178677 and http://crbug.com/178404).
 //   malloc_context_size=5 - limit the size of stack traces collected by ASan
 //     for each malloc/free by 5 frames. These stack traces tend to accumulate
 //     very fast in applications using JIT (v8 in Chrome's case), see
 //     https://code.google.com/p/address-sanitizer/issues/detail?id=177
 //   symbolize=false - disable the in-process symbolization, which isn't 100%
 //     compatible with the existing sandboxes and doesn't make much sense for
 //     stripped official binaries.
 //   legacy_pthread_cond=1 - run in the libpthread 2.2.5 compatibility mode to
 //     work around libGL.so using the obsolete API, see
 //     http://crbug.com/341805. This may break if pthread_cond_t objects are
@@ skipping 16 matching lines @@
 //   detect_stack_use_after_return=1 - use fake stack to delay the reuse of
 //     stack allocations and detect stack-use-after-return errors.
 //   detect_container_overflow=0 - do not detect overflows in containers
 //     until crbug.com/459632 is fixed.
 #if defined(OS_LINUX)
 #if defined(GOOGLE_CHROME_BUILD)
 // Default AddressSanitizer options for the official build. These do not affect
 // tests on buildbots (which don't set GOOGLE_CHROME_BUILD) or non-official
 // Chromium builds.
 const char kAsanDefaultOptions[] =
-    "legacy_pthread_cond=1 malloc_context_size=5 strict_memcmp=0 "
+    "legacy_pthread_cond=1 malloc_context_size=5 "
     "symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
     "strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
     "detect_container_overflow=0 ";
 #else
 // Default AddressSanitizer options for buildbots and non-official builds.
 const char *kAsanDefaultOptions =
-    "strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 "
+    "symbolize=false check_printf=1 use_sigaltstack=1 "
     "detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
     "detect_stack_use_after_return=1 detect_container_overflow=0 ";
 #endif  // GOOGLE_CHROME_BUILD
 
 #elif defined(OS_MACOSX)
 const char *kAsanDefaultOptions =
-    "strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 "
+    "replace_intrin=0 check_printf=1 use_sigaltstack=1 "
     "strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
     "detect_stack_use_after_return=1 detect_odr_violation=0 "
     "detect_container_overflow=0 ";
 static const char kNaClDefaultOptions[] = "handle_segv=0";
 static const char kNaClFlag[] = "--type=nacl-loader";
 #endif  // OS_LINUX
 
 #if defined(OS_LINUX) || defined(OS_MACOSX)
 SANITIZER_HOOK_ATTRIBUTE const char *__asan_default_options() {
 #if defined(OS_MACOSX)
   char*** argvp = _NSGetArgv();
   int* argcp = _NSGetArgc();
   if (!argvp || !argcp) return kAsanDefaultOptions;
   char** argv = *argvp;
   int argc = *argcp;
   for (int i = 0; i < argc; ++i) {
     if (strcmp(argv[i], kNaClFlag) == 0) {
       return kNaClDefaultOptions;
     }
   }
 #endif
   return kAsanDefaultOptions;
 }
+
+extern "C" char kASanDefaultSuppressions[];
+
+SANITIZER_HOOK_ATTRIBUTE const char *__asan_default_suppressions() {
+  return kASanDefaultSuppressions;
+}
 #endif  // OS_LINUX || OS_MACOSX
 #endif  // ADDRESS_SANITIZER
 
 #if defined(THREAD_SANITIZER) && defined(OS_LINUX)
 // Default options for ThreadSanitizer in various configurations:
 //   detect_deadlocks=1 - enable deadlock (lock inversion) detection.
 //   second_deadlock_stack=1 - more verbose deadlock reports.
 //   report_signal_unsafe=0 - do not report async-signal-unsafe functions
 //     called from signal handlers.
 //   report_thread_leaks=0 - do not report unjoined threads at the end of
@@ skipping 32 matching lines @@
   return kLsanDefaultOptions;
 }
 
 extern "C" char kLSanDefaultSuppressions[];
 
 SANITIZER_HOOK_ATTRIBUTE const char *__lsan_default_suppressions() {
   return kLSanDefaultSuppressions;
 }
 
 #endif  // LEAK_SANITIZER