Reset SVGAnimationElement values animation state on attribute changes

Reset SVGAnimationElement values animation state on attribute changes

If the animation element is moved in the DOM, and it is a 'values'
animation, then m_lastValuesAnimation{From,To} would not be reset, which
could mean that if the current from/to values matched those prior to the
move (reinsertion), calculateFromAndtoValues would not be called, and
the SVGAnimateElement::m_{from,to}Type values would not be initialized,
and hence cause a crash when trying to compute the animated value.

BUG=329822
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164599

[fs, 2013-12-20 11:29:01]

PTAL. Scrutiny on the TC would be most appreciated.

[davve, 2013-12-20 11:50:06]

Aside from TC time-out, a non-owner lgtm.

https://codereview.chromium.org/107083007/diff/1/LayoutTests/svg/animations/a...
File LayoutTests/svg/animations/animate-element-reinserted-crash.html (right):

https://codereview.chromium.org/107083007/diff/1/LayoutTests/svg/animations/a...
LayoutTests/svg/animations/animate-element-reinserted-crash.html:27:
window.setTimeout(pass, 1000);
I ran into a similar issue with the TC in
<https://bugs.webkit.org/show_bug.cgi?id=93528>. It's sometimes hard to write
fast and reliable crashers for SVG animations. You need some state to build up,
so hurrying the animation by setting the document clock usually doesn't work.
But 1000ms does sound a little high, not possible to lower?

[fs, 2013-12-20 12:02:05]

On 2013/12/20 11:50:06, David Vest wrote:
>
https://codereview.chromium.org/107083007/diff/1/LayoutTests/svg/animations/a...
> File LayoutTests/svg/animations/animate-element-reinserted-crash.html (right):
> 
>
https://codereview.chromium.org/107083007/diff/1/LayoutTests/svg/animations/a...
> LayoutTests/svg/animations/animate-element-reinserted-crash.html:27:
> window.setTimeout(pass, 1000);
> I ran into a similar issue with the TC in
> <https://bugs.webkit.org/show_bug.cgi?id=93528>. It's sometimes hard to write
> fast and reliable crashers for SVG animations. You need some state to build
up,
> so hurrying the animation by setting the document clock usually doesn't work.
> But 1000ms does sound a little high, not possible to lower?

Yes, should be possible to dial down a bit - it seems to repro reliably even
with at 0, but maybe giving it some slack doesn't feel entirely wrong - 100
looks like a commonly used value, so I'll pick that I think.

[pdr., 2013-12-20 19:19:26]

On 2013/12/20 12:05:44, fs wrote:

LGTM

I would prefer 0 if possible, as extra slack == extra time for everyone's bot
runs.

[fs, 2014-01-07 16:01:45]

0ms it is then.

[commit-bot: I haz the power, 2014-01-07 16:15:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/107083007/70001

[commit-bot: I haz the power, 2014-01-07 17:39:55]

Change committed as 164599