chrome/renderer/extensions/chrome_v8_context.cc - Issue 107083006: More v8-API-related cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_context.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc

index 6d1e9980fcd1edb726c5148bdc849cb49450685c..8fb43360767d02f70ce0cd9d80e1e0425aa4a425 100644

--- a/chrome/renderer/extensions/chrome_v8_context.cc

+++ b/chrome/renderer/extensions/chrome_v8_context.cc

@@ -140,7 +140,7 @@ void ChromeV8Context::OnResponseReceived(const std::string& name,

scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());

v8::Handle<v8::Value> argv[] = {

- v8::Integer::New(request_id),

+ v8::Integer::New(isolate(), request_id),

v8::String::NewFromUtf8(isolate(), name.c_str()),

v8::Boolean::New(isolate(), success),

converter->ToV8Value(&response, v8_context_.NewHandle(isolate())),