chrome/renderer/extensions/app_window_custom_bindings.cc - Issue 107083006: More v8-API-related cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_window_custom_bindings.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/app_window_custom_bindings.cc

diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc

index 975b233c9427a9b50bc65572e2fc77fb9b1537fb..d8c6e0b9503d98f2b4900aeac38e6d3546cea8bc 100644

--- a/chrome/renderer/extensions/app_window_custom_bindings.cc

+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc

@@ -114,7 +114,7 @@ void AppWindowCustomBindings::GetWindowControlsHtmlTemplate(

const v8::FunctionCallbackInfo<v8::Value>& args) {

CHECK_EQ(args.Length(), 0);

- v8::Handle<v8::Value> result = v8::String::Empty();

+ v8::Handle<v8::Value> result = v8::String::Empty(args.GetIsolate());

if (CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableAppWindowControls)) {

base::Value* value = base::Value::CreateStringValue(