Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 107083006: More v8-API-related cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/webstore_bindings.h" 5 #include "chrome/renderer/extensions/webstore_bindings.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "chrome/common/extensions/extension_constants.h" 8 #include "chrome/common/extensions/extension_constants.h"
9 #include "chrome/common/extensions/extension_messages.h" 9 #include "chrome/common/extensions/extension_messages.h"
10 #include "chrome/renderer/extensions/chrome_v8_context.h" 10 #include "chrome/renderer/extensions/chrome_v8_context.h"
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 } 213 }
214 214
215 void WebstoreBindings::OnInlineWebstoreInstallResponse( 215 void WebstoreBindings::OnInlineWebstoreInstallResponse(
216 int install_id, 216 int install_id,
217 bool success, 217 bool success,
218 const std::string& error) { 218 const std::string& error) {
219 v8::Isolate* isolate = context()->isolate(); 219 v8::Isolate* isolate = context()->isolate();
220 v8::HandleScope handle_scope(isolate); 220 v8::HandleScope handle_scope(isolate);
221 v8::Context::Scope context_scope(context()->v8_context()); 221 v8::Context::Scope context_scope(context()->v8_context());
222 v8::Handle<v8::Value> argv[] = { 222 v8::Handle<v8::Value> argv[] = {
223 v8::Integer::New(install_id), 223 v8::Integer::New(isolate, install_id),
224 v8::Boolean::New(isolate, success), 224 v8::Boolean::New(isolate, success),
225 v8::String::NewFromUtf8(isolate, error.c_str()) 225 v8::String::NewFromUtf8(isolate, error.c_str())
226 }; 226 };
227 context()->module_system()->CallModuleMethod( 227 context()->module_system()->CallModuleMethod(
228 "webstore", "onInstallResponse", arraysize(argv), argv); 228 "webstore", "onInstallResponse", arraysize(argv), argv);
229 } 229 }
230 230
231 } // namespace extensions 231 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/set_icon_natives.cc ('k') | content/renderer/gpu/gpu_benchmarking_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698