[PPAPI] API definition for video media stream artifacts

ppapi/cpp/video_frame.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/cpp/video_frame.h"
+
+#include "ppapi/cpp/module.h"
+#include "ppapi/cpp/module_impl.h"
+
+namespace pp {
+
+namespace {
+
+template <> const char* interface_name<PPB_VideoFrame_0_1>() {
+  return PPB_VIDEOFRAME_INTERFACE_0_1;
+}
+
+}
+
+VideoFrame::VideoFrame(PassRef, PP_Resource resource)
+  : Resource(PASS_REF, resource) {

[yzshen1, 2013/12/20 23:37:43]

wrong indent.

[Peng, 2013/12/23 02:41:49]

Done.

+}
+
+VideoFrame::~VideoFrame() {}
+
+PP_TimeDelta VideoFrame::GetTimestamp() const {
+  PP_TimeDelta timestamp = .0;
+  if (!has_interface<PPB_VideoFrame_0_1>()) {

[yzshen1, 2013/12/20 23:37:43]

The condition of if() is incorrect.

[Peng, 2013/12/23 02:41:49]

Done.

+    timestamp = get_interface<PPB_VideoFrame_0_1>()->GetTimestamp(
+        pp_resource());
+  }
+  return timestamp;
+}
+
+void VideoFrame::SetTimestamp(PP_TimeDelta timestamp) {
+  if (has_interface<PPB_VideoFrame_0_1>()) {

[yzshen1, 2013/12/20 23:37:43]

nit: no need to have {}

[Peng, 2013/12/23 02:41:49]

Done.

+    get_interface<PPB_VideoFrame_0_1>()->SetTimestamp(pp_resource(), timestamp);
+  }
+}
+
+PP_VideoFrame_Format VideoFrame::GetFormat() const {
+  if (!has_interface<PPB_VideoFrame_0_1>())

[yzshen1, 2013/12/20 23:37:43]

nit, optional: I would prefer to always test has_interface() or
!has_interface(). Usually we test has_interface() because it is easy to add
fallbacks when there are multiple versions of API.

[Peng, 2013/12/23 02:41:49]

Done.

+    return PP_VIDEOFRAME_FORMAT_UNKNOWN;
+  return get_interface<PPB_VideoFrame_0_1>()->GetFormat(pp_resource());
+}
+
+const Size VideoFrame::GetSize() const {
+  Size size;
+  if (has_interface<PPB_VideoFrame_0_1>()) {
+    get_interface<PPB_VideoFrame_0_1>()->GetSize(pp_resource(),
+                                                 &size.pp_size());
+  }
+  return size;
+}
+
+void* VideoFrame::GetDataBuffer() {
+  if (!has_interface<PPB_VideoFrame_0_1>())
+    return NULL;
+  return get_interface<PPB_VideoFrame_0_1>()->GetDataBuffer(pp_resource());
+}
+
+uint32_t VideoFrame::GetDataBufferSize() const {
+  int32_t size = 0;

[yzshen1, 2013/12/20 23:37:43]

uint32_t

[Peng, 2013/12/23 02:41:49]

Done.

+  if (has_interface<PPB_VideoFrame_0_1>()) {
+    size = get_interface<PPB_VideoFrame_0_1>()->GetDataBufferSize(
+        pp_resource());
+  }
+  return (size >= 0) ? size : 0;

[yzshen1, 2013/12/20 23:37:43]

You don't need this check if |size| is uint32_t

[Peng, 2013/12/23 02:41:49]

Done.

+}
+
+}  // namespace pp