Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1070803002: [crankshaft] Fix interceptor shadowing constant global property. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix interceptor shadowing constant global property. This makes sure Crankshaft respects interceptors in the global object even when they shadow a constant global property. R=verwaest@chromium.org TEST=cctest/test-api-interceptors/PrePropertyHandler Committed: https://crrev.com/7196ea72c8d77944108b9e38c4f084ef2b8b79ad Cr-Commit-Position: refs/heads/master@{#27733}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/hydrogen.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-08 15:50:30 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-09 18:10:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070803002/20001
5 years, 8 months ago (2015-04-10 08:29:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 08:30:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 08:30:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7196ea72c8d77944108b9e38c4f084ef2b8b79ad
Cr-Commit-Position: refs/heads/master@{#27733}

Powered by Google App Engine
This is Rietveld 408576698