Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 1070753004: Bump iossim default device to 'iPhone 5s'. (Closed)

Created:
5 years, 8 months ago by justincohen
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bump iossim default device to 'iPhone 5s'. iOS builds now default to 64-bit (codereview.chromium.org/1021513002). Bump default device to iPhone 5s, which supports 64-bit binaries. BUG=None TEST=iossim works without passing any device flags. Committed: https://crrev.com/cb1a6ec0053492be868f52711138cf3f158e71f9 Cr-Commit-Position: refs/heads/master@{#324283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/iossim/iossim.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
justincohen
PTAL
5 years, 8 months ago (2015-04-08 18:39:31 UTC) #2
rohitrao (ping after 24h)
lgtm
5 years, 8 months ago (2015-04-08 18:52:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070753004/1
5 years, 8 months ago (2015-04-08 18:54:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 20:55:03 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 20:56:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb1a6ec0053492be868f52711138cf3f158e71f9
Cr-Commit-Position: refs/heads/master@{#324283}

Powered by Google App Engine
This is Rietveld 408576698