Introduce DEFINE_DOCUMENT_TYPE_CASTS, and use it

Introduce DEFINE_DOCUMENT_TYPE_CASTS, and use it

As a step to use DEFINE_TYPE_CASTS, this cl introduce DEFINE_DOCUMENT_TYPE_CASTS.
It's used by HTMLDocument, ImageDocument, PluginDocument, and SVGDocument in order to replace
manual toFoo() with generated toFoo() which supports all cast functions.

BUG=309516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163404

[tkent, 2013-12-09 00:17:27]

https://codereview.chromium.org/107073003/diff/20001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/107073003/diff/20001/Source/core/dom/Document...
Source/core/dom/Document.h:1349: #define
DEFINE_DOCUMENT_CASTS_WITH_FUNCTION(thisType) \
This is inconsistent with others.

* We usually name it DEFINE_DOCUMENT_*TYPE*_CASTS(_WITH_FUNCTION).

* This has the suffix _WITH_FUNCTION, but it doesn't require
WebCore::isFooDocument() functions. It works well with
WebCore::Document::isFooDocument() and we don't need to call it _WITH_FUNCTION.

[gyuyoung-inactive, 2013-12-09 03:58:09]

https://codereview.chromium.org/107073003/diff/20001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/107073003/diff/20001/Source/core/dom/Document...
Source/core/dom/Document.h:1349: #define
DEFINE_DOCUMENT_CASTS_WITH_FUNCTION(thisType) \
On 2013/12/09 00:17:27, tkent wrote:
> This is inconsistent with others.
> 
> * We usually name it DEFINE_DOCUMENT_*TYPE*_CASTS(_WITH_FUNCTION).

Fixed.

> * This has the suffix _WITH_FUNCTION, but it doesn't require
> WebCore::isFooDocument() functions. It works well with
> WebCore::Document::isFooDocument() and we don't need to call it
_WITH_FUNCTION.
> 

I don't mind to use the macro without _WITH_FUNCTION. Fixed.

[tkent, 2013-12-09 04:08:17]

https://codereview.chromium.org/107073003/diff/80001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/107073003/diff/80001/Source/core/dom/Document...
Source/core/dom/Document.h:1350: #define DEFINE_DOCUMENT_TYPE_CASTS(thisType,
predicate) \
You don't need to add the second argument.  Implementation of this macro in
Patch Set 1 was correct.

[gyuyoung-inactive, 2013-12-09 04:42:27]

https://codereview.chromium.org/107073003/diff/80001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/107073003/diff/80001/Source/core/dom/Document...
Source/core/dom/Document.h:1350: #define DEFINE_DOCUMENT_TYPE_CASTS(thisType,
predicate) \
On 2013/12/09 04:08:17, tkent wrote:
> You don't need to add the second argument.  Implementation of this macro in
> Patch Set 1 was correct.

Oops, I misunderstand your comment. Sorry about it. Fixed again.

[tkent, 2013-12-09 04:54:33]

please update the CL description.

[gyuyoung-inactive, 2013-12-09 05:06:27]

On 2013/12/09 04:54:33, tkent wrote:
> please update the CL description.

Updated.

[tkent, 2013-12-09 05:12:29]

https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Documen...
Source/core/dom/Document.h:1350: #define
DEFINE_DOCUMENT_TYPE_CASTS_WITH_FUNCTION(thisType) \
As I already wrote, this function should not have _WITH_FUNCTION suffix.

DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION means it uses WebCore::isFoo(), not member
functions of a class.  DEIFNE_DOCUMENT_TYPE_CASTS doesn't use
WebCore::isFooDocument().

[gyuyoung-inactive, 2013-12-09 05:17:17]

On 2013/12/09 05:12:29, tkent wrote:
>
https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Document.h
> File Source/core/dom/Document.h (right):
> 
>
https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Documen...
> Source/core/dom/Document.h:1350: #define
> DEFINE_DOCUMENT_TYPE_CASTS_WITH_FUNCTION(thisType) \
> As I already wrote, this function should not have _WITH_FUNCTION suffix.
> 
> DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION means it uses WebCore::isFoo(), not
member
> functions of a class.  DEIFNE_DOCUMENT_TYPE_CASTS doesn't use
> WebCore::isFooDocument().

Do you mean "_WITH_FUNCTION" only should be removed, right ?

[gyuyoung-inactive, 2013-12-09 05:36:46]

On 2013/12/09 05:17:17, gyuyoung wrote:
> On 2013/12/09 05:12:29, tkent wrote:
> >
>
https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Document.h
> > File Source/core/dom/Document.h (right):
> > 
> >
>
https://codereview.chromium.org/107073003/diff/100001/Source/core/dom/Documen...
> > Source/core/dom/Document.h:1350: #define
> > DEFINE_DOCUMENT_TYPE_CASTS_WITH_FUNCTION(thisType) \
> > As I already wrote, this function should not have _WITH_FUNCTION suffix.
> > 
> > DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION means it uses WebCore::isFoo(), not
> member
> > functions of a class.  DEIFNE_DOCUMENT_TYPE_CASTS doesn't use
> > WebCore::isFooDocument().
> 
> Do you mean "_WITH_FUNCTION" only should be removed, right ?

I hope this patch is thing you want.

[tkent, 2013-12-09 05:56:29]

lgtm

[commit-bot: I haz the power, 2013-12-09 05:56:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/107073003/120001

[commit-bot: I haz the power, 2013-12-09 07:55:48]

Change committed as 163404