Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1070693002: Partial revert of "Added metrics to count the number of items in the shelf." (Closed)

Created:
5 years, 8 months ago by bruthig
Modified:
5 years, 8 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, skuhne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial revert of "Added metrics to count the number of items in the shelf." Collecting the metrics was sometimes causing a crash and has been removed until the root cause is found. This is only a partial revert because items are not to be removed from tools/metrics/histograms/histograms.xml. BUG=474702 Committed: https://crrev.com/917c61c1a5859243b159c86d42c4d8f7f523412d Cr-Commit-Position: refs/heads/master@{#324226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M ash/metrics/user_metrics_recorder.cc View 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bruthig
derat@, can you please have a look?
5 years, 8 months ago (2015-04-08 13:01:44 UTC) #2
Daniel Erat
lgtm
5 years, 8 months ago (2015-04-08 13:02:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070693002/1
5 years, 8 months ago (2015-04-08 13:03:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 14:37:44 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 14:38:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/917c61c1a5859243b159c86d42c4d8f7f523412d
Cr-Commit-Position: refs/heads/master@{#324226}

Powered by Google App Engine
This is Rietveld 408576698