Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1070653002: VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. R=verwaest@chromium.org BUG= Committed: https://crrev.com/2395eda3bb7aca938751938df76e01ac2b89b0a6 Cr-Commit-Position: refs/heads/master@{#27657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
mvstanton
Hi Toon, Let's light up the sky. --Michael
5 years, 8 months ago (2015-04-08 09:13:08 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-08 09:13:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070653002/1
5 years, 8 months ago (2015-04-08 09:14:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 11:12:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2395eda3bb7aca938751938df76e01ac2b89b0a6 Cr-Commit-Position: refs/heads/master@{#27657}
5 years, 8 months ago (2015-04-08 11:12:58 UTC) #6
mvstanton
5 years, 8 months ago (2015-04-08 12:52:15 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1072463002/ by mvstanton@chromium.org.

The reason for reverting is: ARM test failure, need to investigate..

Powered by Google App Engine
This is Rietveld 408576698