Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1070603003: base::ManualConstructor improvements (Closed)

Created:
5 years, 8 months ago by Mikhail
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base::ManualConstructor improvements - use ALIGNOF macro - use variadic templates Committed: https://crrev.com/fcedd76a70ed85c1a24b2ac9bafe684c34d0e038 Cr-Commit-Position: refs/heads/master@{#324417}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed the outdated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -60 lines) Patch
M base/memory/manual_constructor.h View 1 4 chunks +6 lines, -60 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Mikhail
PTAl
5 years, 8 months ago (2015-04-08 11:49:41 UTC) #2
Nico
lgtm! https://codereview.chromium.org/1070603003/diff/1/base/memory/manual_constructor.h File base/memory/manual_constructor.h (right): https://codereview.chromium.org/1070603003/diff/1/base/memory/manual_constructor.h#newcode56 base/memory/manual_constructor.h:56: // You can pass up to eight constructor ...
5 years, 8 months ago (2015-04-08 17:37:16 UTC) #3
Nico
On 2015/04/08 17:37:16, Nico wrote: > lgtm! > > https://codereview.chromium.org/1070603003/diff/1/base/memory/manual_constructor.h > File base/memory/manual_constructor.h (right): > ...
5 years, 8 months ago (2015-04-08 18:45:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070603003/20001
5 years, 8 months ago (2015-04-09 09:13:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 12:11:14 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 12:12:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcedd76a70ed85c1a24b2ac9bafe684c34d0e038
Cr-Commit-Position: refs/heads/master@{#324417}

Powered by Google App Engine
This is Rietveld 408576698