Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1070593002: Unbreak check-name-clashes.py after recent macro renamings. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unbreak check-name-clashes.py after recent macro renamings. This should have been part of https://codereview.chromium.org/1056863002/. :-/ TBR=jkummerow@chromium.org Committed: https://crrev.com/a326fd86edf5f5a4083c4799ad26d3e831231aad Cr-Commit-Position: refs/heads/master@{#27647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/check-name-clashes.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070593002/1
5 years, 8 months ago (2015-04-08 06:42:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 07:04:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a326fd86edf5f5a4083c4799ad26d3e831231aad Cr-Commit-Position: refs/heads/master@{#27647}
5 years, 8 months ago (2015-04-08 07:04:21 UTC) #4
Jakob Kummerow
5 years, 8 months ago (2015-04-08 08:06:47 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698