Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1070553005: Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@b444955
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set frame liveness before calling RenderFrameCreated/RenderFrameDeleted. In the FrameTree unittests, illustrate the liveness of frames in the ASCII dumps. Update some tests so that children aren't born to dead parents. BUG=474231 Committed: https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f Cr-Commit-Position: refs/heads/master@{#325508}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/browser/frame_host/frame_tree_unittest.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ncarter (slow)
Nasko: let me know what you think about this. This shouldn't affect existing clients as ...
5 years, 8 months ago (2015-04-15 21:59:35 UTC) #2
nasko
LGTM
5 years, 8 months ago (2015-04-15 22:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070553005/20001
5 years, 8 months ago (2015-04-16 19:43:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 20:44:47 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ad74a7e371149624d91f96cf662f70af6d18787f Cr-Commit-Position: refs/heads/master@{#325508}
5 years, 8 months ago (2015-04-16 20:45:40 UTC) #7
johnme
5 years, 8 months ago (2015-04-17 14:03:25 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1086613003/ by johnme@chromium.org.

The reason for reverting is: Tentative revert to try to fix
BrowserTest.WindowOpenClose, which is consistently failing on chromium.webkit
Mac10.6 Tests and Mac10.8 Tests.

It times out during
ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete and
gets killed whilst waiting for the navigations.

It started failing between
https://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/474
and
https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/...,
so the blamelists are:

Chromium:
https://chromium.googlesource.com/chromium/src.git/+log/96626920573e30a2cd020...

Blink:
https://chromium.googlesource.com/chromium/blink/+log/7f9db67d6a96399f8e4eae4...

This is the only patch that seems at all relevant from amongst those....

Powered by Google App Engine
This is Rietveld 408576698