Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1070523002: Revert of Add the ability to build Chrome tools to the Win Clang build script. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
hans, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the ability to build Chrome tools to the Win Clang build script. (patchset #3 id:40001 of https://codereview.chromium.org/1068603002/) Reason for revert: Still breaks clang/win bots: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/279 Original issue's description: > Add the ability to build Chrome tools to the Win Clang build script. > > BUG=424436, 467287 > > Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b > Cr-Commit-Position: refs/heads/master@{#324089} > > Committed: https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97 > Cr-Commit-Position: refs/heads/master@{#324164} TBR=hans@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=424436, 467287 Committed: https://crrev.com/615d79986581d6cfbcc25d805b15483603dd5c40 Cr-Commit-Position: refs/heads/master@{#324178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -49 lines) Patch
M tools/clang/scripts/update.py View 6 chunks +7 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add the ability to build Chrome tools to the Win Clang build ...
5 years, 8 months ago (2015-04-08 02:31:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070523002/1
5 years, 8 months ago (2015-04-08 02:32:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 02:33:05 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 02:34:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/615d79986581d6cfbcc25d805b15483603dd5c40
Cr-Commit-Position: refs/heads/master@{#324178}

Powered by Google App Engine
This is Rietveld 408576698