Issue 1070463003: Initialize command line arguments for Mojo apptests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1070463003: Initialize command line arguments for Mojo apptests. (Closed)

Created:
5 years, 8 months ago by msw

Modified:
5 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Abandoned in favor of the re-landed https://codereview.chromium.org/1057603003/ Initialize command line arguments for Mojo apptests. ApplicationImpl args were broken in a recent CL: https://codereview.chromium.org/1057603003/ These were used by apptests for fixture isolation, etc. (see mojo/tools/apptest_runner.py) TODO: Restore --url-mappings to mock out service dependencies. BUG=NONE (392646?) R=jam@chromium.org TEST="mojo_shell mojo:network_service_apptests --gtest_list_tests" works.

Patch Set 1 #

Patch Set 2 : Restoring url-mappings and specifying test apps on the commandline. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -12 lines)			Patch
M	mojo/application/application_runner_chromium.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/application/application_runner_chromium.cc	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	mojo/application/application_test_main_chromium.cc	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	mojo/services/html_viewer/ax_provider_apptest.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	mojo/shell/context.cc	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	mojo/shell/desktop/launcher_process.cc	View	1	5 chunks	+47 lines, -2 lines	0 comments	Download
M	mojo/shell/switches.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/shell/switches.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	mojo/tools/apptest_runner.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/tools/gtest.py	View	1	1 chunk	+1 line, -3 lines	0 comments	Download