Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1070423003: Set display mode for extensions::AppWindow (Closed)

Created:
5 years, 8 months ago by Mikhail
Modified:
5 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@display_mode
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set display mode for extensions::AppWindow This CL provides content::WebContentsDelegate::GetDisplayMode() implementation for extensions::AppWindow. The 'extensions/api_test/fullscreen/' test is modified to verify media query "display-mode" features correctness. BUG=471703 Committed: https://crrev.com/d15048d49fee7167c57825bba4d899a7effcad3a Cr-Commit-Position: refs/heads/master@{#326502}

Patch Set 1 : #

Patch Set 2 : Added api test #

Patch Set 3 : Added license header to check_media_feature.js #

Patch Set 4 : Disabled API test on MAC #

Patch Set 5 : Added a reference to bug. #

Messages

Total messages: 22 (9 generated)
scheib
This patch enables manual testing, but doesn't have any automated test expecting the result. Should ...
5 years, 8 months ago (2015-04-13 17:52:02 UTC) #3
Mikhail
On 2015/04/13 17:52:02, scheib wrote: > This patch enables manual testing, but doesn't have any ...
5 years, 8 months ago (2015-04-14 13:24:34 UTC) #4
scheib
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/extensions/extension_fullscreen_apitest.cc Calling https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/extensions/api_test/fullscreen
5 years, 8 months ago (2015-04-15 20:15:25 UTC) #5
Mikhail
On 2015/04/15 20:15:25, scheib wrote: > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/extensions/extension_fullscreen_apitest.cc > > Calling > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/extensions/api_test/fullscreen Thanks for ...
5 years, 8 months ago (2015-04-16 15:11:11 UTC) #6
Mikhail
On 2015/04/16 15:11:11, Mikhail wrote: > On 2015/04/15 20:15:25, scheib wrote: > > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/extensions/extension_fullscreen_apitest.cc ...
5 years, 8 months ago (2015-04-20 09:52:47 UTC) #7
scheib
LGTM
5 years, 8 months ago (2015-04-20 17:27:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070423003/40001
5 years, 8 months ago (2015-04-21 06:18:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57641)
5 years, 8 months ago (2015-04-21 06:26:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070423003/60001
5 years, 8 months ago (2015-04-21 06:56:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/57340)
5 years, 8 months ago (2015-04-21 10:58:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070423003/100001
5 years, 8 months ago (2015-04-23 11:28:58 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 8 months ago (2015-04-23 13:31:24 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 13:32:15 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d15048d49fee7167c57825bba4d899a7effcad3a
Cr-Commit-Position: refs/heads/master@{#326502}

Powered by Google App Engine
This is Rietveld 408576698