Issue 1070393002: Remove a bunch of cruft from PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1070393002: Remove a bunch of cruft from PRESUBMIT.py. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -412 lines)			Patch
	M	PRESUBMIT.py	View	1	17 chunks	+29 lines, -301 lines	0 comments	Download
	M	PRESUBMIT_test.py	View	1	2 chunks	+2 lines, -111 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

lgtm (we don't have/check OWNERS files here so that stuff can be nuked too)

5 years, 8 months ago (2015-04-09 22:32:48 UTC) #2

viettrungluu

Thanks. On 2015/04/09 22:32:48, jamesr wrote: > lgtm > > (we don't have/check OWNERS files ...

5 years, 8 months ago (2015-04-09 22:43:59 UTC) #3

viettrungluu

5 years, 8 months ago (2015-04-09 22:45:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0d4fef68cb4ba4257aa76bf5a8d48dda36f465ae (presubmit successful).