Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1070353003: Revert of Build the Clang plugin on Windows. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build the Clang plugin on Windows. (patchset #6 id:100001 of https://codereview.chromium.org/1072203002/) Reason for revert: Not all the Windows bots have CMake 3.1+. Original issue's description: > Build the Clang plugin on Windows. > > This also includes several fixes for the plugin logic on Windows: > - The banned directory check normalizes path separators. > - The banned directory check now returns true for files that are > considered system headers. > - Diagnostics from the plugin are always reported as warnings. > > BUG=467287 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20 TBR=hans@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467287 Committed: https://crrev.com/627a8417950a65559f58c756a902fdfff7de5dbf Cr-Commit-Position: refs/heads/master@{#324795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -47 lines) Patch
M tools/clang/plugins/CMakeLists.txt View 1 chunk +12 lines, -30 lines 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 4 chunks +1 line, -10 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Created Revert of Build the Clang plugin on Windows.
5 years, 8 months ago (2015-04-12 07:33:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1070353003/1
5 years, 8 months ago (2015-04-12 07:33:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-12 07:33:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/627a8417950a65559f58c756a902fdfff7de5dbf Cr-Commit-Position: refs/heads/master@{#324795}
5 years, 8 months ago (2015-04-12 07:35:41 UTC) #4
Nico
5 years, 8 months ago (2015-04-13 00:07:36 UTC) #5
Message was sent while issue was closed.
Looks like this revert wasn't enough, this is still causing trouble on these two
bots:

http://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD
http://build.chromium.org/p/chromium.fyi/builders/CrWinAsan

(I think they're the same physical machine; maybe that's the only without cmake
3.1)

Powered by Google App Engine
This is Rietveld 408576698