sky/engine/core/rendering/RenderBlock.cpp - Issue 1070313003: Remove page-break properties and captions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlock.cpp

Issue 1070313003: Remove page-break properties and captions (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlock.cpp

diff --git a/sky/engine/core/rendering/RenderBlock.cpp b/sky/engine/core/rendering/RenderBlock.cpp

index f70c0888fef056c9c6446f6d6f26c336603b1825..84376b61e61f007fb6dde25078a80e20db743a64 100644

--- a/sky/engine/core/rendering/RenderBlock.cpp

+++ b/sky/engine/core/rendering/RenderBlock.cpp

@@ -1113,9 +1113,6 @@ PositionWithAffinity RenderBlock::positionForPointWithInlineChildren(const Layou

if (!firstRootBoxWithChildren)

firstRootBoxWithChildren = root;

- if (root->isFirstAfterPageBreak() && (pointInLogicalContents.y() < root->lineTopWithLeading()))

- break;

lastRootBoxWithChildren = root;

// check if this root line box is located at this y coordinate