Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1070313003: Remove page-break properties and captions (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove page-break properties and captions We want some sort of per-screen breaking, but this CSS is not the way to do it. All of this was already dead code. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/db76e5a1579571a1eb0611653a4f714786efc6fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -167 lines) Patch
M sky/engine/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 4 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -77 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 4 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RootInlineBox.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 12 chunks +0 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hixie
lgtm
5 years, 8 months ago (2015-04-09 21:38:03 UTC) #1
eseidel
5 years, 8 months ago (2015-04-09 21:39:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db76e5a1579571a1eb0611653a4f714786efc6fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698