Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5381)

Unified Diff: chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc

Issue 1070273003: Dismiss DevicePermissionsPrompt when the widgets are destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc b/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
index 773a85df6d2ef446345bc5a754e7a22e4c205da2..9a3c7b2ff40297fc5ce1ac7e3e1a7fefc8632c2a 100644
--- a/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
@@ -120,16 +120,17 @@ DevicePermissionsDialogView::~DevicePermissionsDialogView() {
RemoveAllChildViews(true);
}
-bool DevicePermissionsDialogView::Cancel() {
+void DevicePermissionsDialogView::DeleteDelegate() {
+ // Dismissing the prompt here catches all the possible ways that this view can
+ // be closed including the unexpected closure of its parent.
Peter Kasting 2015/04/20 21:33:33 Nit: How about: Calling prompt_->Dismissed() here
Reilly Grant (use Gerrit) 2015/04/20 23:14:49 Done.
prompt_->Dismissed();
- return true;
+ delete this;
}
bool DevicePermissionsDialogView::Accept() {
for (int index : table_view_->selection_model().selected_indices()) {
prompt_->GrantDevicePermission(index);
}
- prompt_->Dismissed();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698