Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: sky/engine/core/css/parser/CSSPropertyParser.cpp

Issue 1070263002: remove CSS quotes property (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/css/parser/CSSPropertyParser.cpp
diff --git a/sky/engine/core/css/parser/CSSPropertyParser.cpp b/sky/engine/core/css/parser/CSSPropertyParser.cpp
index 438960ff5678b1d831f57902855881817659b02f..3a90928911a4092e1877610b1e2f4983975bba79 100644
--- a/sky/engine/core/css/parser/CSSPropertyParser.cpp
+++ b/sky/engine/core/css/parser/CSSPropertyParser.cpp
@@ -451,13 +451,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId)
case CSSPropertySize: // <length>{1,2} | auto | [ <page-size> || [ portrait | landscape] ]
return parseSize(propId);
- case CSSPropertyQuotes: // [<string> <string>]+ | none
- if (id == CSSValueNone)
- validPrimitive = true;
- else
- parsedValue = parseQuotes();
- break;
-
case CSSPropertyClip: // <shape> | auto | inherit
if (id == CSSValueAuto)
validPrimitive = true;
@@ -1662,23 +1655,6 @@ CSSPropertyParser::SizeParameterType CSSPropertyParser::parseSizeParameter(CSSVa
}
}
-// [ <string> <string> ]+ | none, but none is handled in parseValue
-PassRefPtr<CSSValue> CSSPropertyParser::parseQuotes()
-{
- RefPtr<CSSValueList> values = CSSValueList::createCommaSeparated();
- while (CSSParserValue* val = m_valueList->current()) {
- RefPtr<CSSValue> parsedValue = nullptr;
- if (val->unit != CSSPrimitiveValue::CSS_STRING)
- return nullptr;
- parsedValue = CSSPrimitiveValue::create(val->string, CSSPrimitiveValue::CSS_STRING);
- values->append(parsedValue.release());
- m_valueList->next();
- }
- if (values->length() && values->length() % 2 == 0)
- return values.release();
- return nullptr;
-}
-
PassRefPtr<CSSValue> CSSPropertyParser::parseAttr(CSSParserValueList* args)
{
if (args->size() != 1)
« no previous file with comments | « sky/engine/core/css/parser/CSSPropertyParser.h ('k') | sky/engine/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698