Allow widevinecdmadapter to be built in Chromium with GN

third_party/widevine/cdm/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//chrome/version.gni")  # TODO layering violation
 import("//media/cdm/ppapi/cdm_adapter.gni")
+import("//third_party/widevine/cdm/widevine.gni")
 
 widevine_arch = current_cpu
 if (widevine_arch == "x86") {
   widevine_arch = "ia32"
 }
 
 if (is_android) {
   # Always available on Android regardless of branding.
   widevine_cdm_version_h_file = "android/widevine_cdm_version.h"
   widevine_cdm_binary_files = []
@@ skipping 12 matching lines @@
       "win/$widevine_arch/widevinecdm.dll.lib",
     ]
   } else if (is_mac) {
     widevine_cdm_version_h_file = "mac/$widevine_arch/widevine_cdm_version.h"
     widevine_cdm_binary_files = [ "mac/$widevine_arch/libwidevinecdm.dylib" ]
   } else {
     # Other platforms, use the default one.
     widevine_cdm_version_h_file = "widevine_cdm_version.h"
     widevine_cdm_binary_files = []
   }
+} else if (enable_widevine) {
+  widevine_cdm_version_h_file = "stub/widevine_cdm_version.h"
+  widevine_cdm_binary_files = []
 } else {
   # No branding, use the default one.
   widevine_cdm_version_h_file = "widevine_cdm_version.h"
   widevine_cdm_binary_files = []
 }
 
 # GYP version: third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h
 copy("version_h") {
   sources = [
     widevine_cdm_version_h_file,
   ]
 
   # TODO(brettw) this should go into target_out_dir and callers should include
   # it from there. This requires, however, renaming the default
   # widevine_cdm_version.h in this directory to avoid conflicts.
   outputs = [
     "$root_gen_dir/widevine_cdm_version.h",
   ]
 }
 
-# GYP version: third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_binaries
-if (widevine_cdm_binary_files == []) {
-  group("binaries") {
-    # NOP
-  }
-} else {
-  copy("binaries") {
+# GYP version: third_party/widevine/cdm/widevine_cdm.gyp:widevinecdm
+if (widevine_cdm_binary_files != []) {

[DaleCurtis, 2015/04/13 18:35:58]

is the != [] necessary, does !widevine_cdm_binary_files work?

[jrummell, 2015/04/13 22:22:35]

Doesn't work. Error is "Operand of ! operator is not a boolean. Type is "list"
instead."

+  copy("widevinecdm") {
     sources = widevine_cdm_binary_files
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
 
     # TODO(GYP)

[xhwang, 2015/04/14 21:27:30]

Here and below, put a real name after TODO.

[jrummell, 2015/04/14 22:47:43]

Done.

     # 'COPY_PHASE_STRIP': 'NO',
   }
+} else if (!is_android && !is_chrome_branded && enable_widevine) {

[xhwang, 2015/04/14 21:27:30]

Can we do something like?

else if (!is_android && enable_widevine) {
  assert(!is_chrome_branded, "Branded Chrome should have binary files to copy.")

[xhwang, 2015/04/14 21:27:30]

Here !is_android is pretty much the same as enable_pepper_cdms (used on l.110).
Maybe we should be consistent on this. I think enable_pepper_cdms makes more
sense because the CDM needs pepper to work.

[jrummell, 2015/04/14 22:47:43]

Done.

[jrummell, 2015/04/14 22:47:43]

Done.

+  # TODO(GYP) On Mac/Linux this should be a loadable_module.

[jrummell, 2015/04/14 22:47:43]

Removed this TODO since it came from cdm_adapter template, and clearkeycdm
doesn't have it. Plus there isn't loadable_module in GN anyway.

+  shared_library("widevinecdm") {
+    sources = [
+      "//media/cdm/stub/stub_cdm.cc",
+      "//media/cdm/stub/stub_cdm.h",
+    ]
+
+    defines = [ "CDM_IMPLEMENTATION" ]
+
+    deps = [
+      ":version_h",
+      "//base",
+    ]
+
+    if (is_mac) {
+      ldflags = [
+        # Not to strip important symbols by -Wl,-dead_strip.
+        "-Wl,-exported_symbol,_PPP_GetInterface",
+        "-Wl,-exported_symbol,_PPP_InitializeModule",
+        "-Wl,-exported_symbol,_PPP_ShutdownModule",
+      ]
+      #TODO(GYP) Mac: 'DYLIB_INSTALL_NAME_BASE': '@loader_path',
+    } else if (is_posix && !is_mac) {
+      cflags = [ "-fvisibility=hidden" ]
+      # Note GYP sets rpath but this is set by default on shared libraries in
+      # the GN build.
+    }
+  }
+} else {
+  group("widevinecdm") {
+    # NOP
+  }
 }
 
-if (is_chrome_branded && enable_pepper_cdms) {
+if ((is_chrome_branded || enable_widevine) && enable_pepper_cdms) {
   adapter_resource_file = "$target_gen_dir/widevinecdmadapter_version.rc"
 
   # Produce the .rc file.
-  process_version("adapter_resources") {
+  process_version("widevinecdmadapter_resources") {
     visibility = [ ":*" ]
     sources = [
       "BRANDING",
       "widevinecdmadapter.ver",
     ]
     output = adapter_resource_file
   }
 
-  cdm_adapter("adapter") {
+  cdm_adapter("widevinecdmadapter") {
     sources = [
       adapter_resource_file,
     ]
     deps = [
-      ":adapter_resources",
-      ":binaries",
+      ":widevinecdmadapter_resources",
+      ":widevinecdm",
       ":version_h",
       "//ppapi/cpp",
     ]
 
     if (is_linux) {
       ldflags =
           [ rebase_path("$root_out_dir/libwidevinecdm.so", root_build_dir) ]

[jrummell, 2015/04/09 21:44:17]

Not sure if the rebase_path() is needed now that the tag is set properly.

[DaleCurtis, 2015/04/13 18:35:58]

Does it build without it ? :)

[jrummell, 2015/04/13 22:22:35]

It does. However, this appears to be the standard pattern in clearkeycdmadapter
and ffmpeg, so leaving it alone.

       libs = [ "rt" ]
     } else if (is_win) {
       ldflags =
           [ rebase_path("$root_out_dir/widevinecdm.dll.lib", root_build_dir) ]
     } else if (is_mac) {
       ldflags =
           [ rebase_path("$root_out_dir/libwidevinecdm.dylib", root_build_dir) ]
     }
   }
 } else {
   # Placeholder when we're not compiling the adapter.
-  group("adapter") {
+  group("widevinecdmadapter") {
   }
 }
 
 # This target exists for tests to depend on that pulls in a runtime dependency
 # on the license server.
 source_set("widevine_test_license_server") {
   if (is_chrome_branded && is_linux) {
     deps = [
       # TODO(GYP)
       # This target should be removed and targets should have datadeps on this target:
       #"//third_party/widevine/test/license_server/license_server.gyp:test_license_server"
     ]
   }
 }