Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 1070233007: Stop adding the "files/" prefix when sending open_resource IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index e91c8ff967a6fdb092f80b48274b594390fc71d3..c879e48671bf9e1cb00fc42c3325ba6d162bf16f 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -1107,18 +1107,8 @@ bool ManifestResolveKey(PP_Instance instance,
// keys manually as there is no existing .nmf file to parse.
if (is_helper_process) {
pnacl_options->translate = PP_FALSE;
- // We can only resolve keys in the files/ namespace.
- const std::string kFilesPrefix = "files/";
- if (key.find(kFilesPrefix) == std::string::npos) {
- nacl::NexeLoadManager* load_manager = GetNexeLoadManager(instance);
- if (load_manager)
- load_manager->ReportLoadError(PP_NACL_ERROR_MANIFEST_RESOLVE_URL,
- "key did not start with files/");
- return false;
- }
- std::string key_basename = key.substr(kFilesPrefix.length());
*full_url = std::string(kPNaClTranslatorBaseUrl) + GetSandboxArch() + "/" +
- key_basename;
+ key;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698