Fix intermittent connection failure in CRD.

remoting/protocol/libjingle_transport_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/libjingle_transport_factory.h"
 
 #include <algorithm>
 
 #include "base/callback.h"
 #include "base/callback_helpers.h"
@@ skipping 132 matching lines @@
   DCHECK(CalledOnValidThread());
 
   DCHECK(!can_start_);
   can_start_ = true;
 
   // If Connect() has been called then start connection.
   if (!callback_.is_null())
     DoStart();
 
   while (!pending_candidates_.empty()) {
+    channel_->SetRemoteIceCredentials(pending_candidates_.front().username(),
+                                      pending_candidates_.front().password());

[jiayl, 2015/04/15 20:13:00]

Do all candidates share the same username/password? Add a check for that, and
call SetRemoteIceCredentials just once?

[Sergey Ulanov, 2015/04/15 20:49:34]

Credentials may change when the remote peer restarts ICE. We could call
SetRemoteIceCredentials() only when they change, but it looks like
SetRemoteIceCredentials() verifies it anyway, so I'm not sure we would get
anything from duplicating the same check here.

     channel_->OnCandidate(pending_candidates_.front());
     pending_candidates_.pop_front();
   }
 }
 
 void LibjingleTransport::Connect(
     const std::string& name,
     Transport::EventHandler* event_handler,
     const Transport::ConnectedCallback& callback) {
   DCHECK(CalledOnValidThread());
@@ skipping 58 matching lines @@
   DCHECK(CalledOnValidThread());
 
   // To enforce the no-relay setting, it's not enough to not produce relay
   // candidates. It's also necessary to discard remote relay candidates.
   bool relay_allowed = (network_settings_.flags &
                         NetworkSettings::NAT_TRAVERSAL_RELAY) != 0;
   if (!relay_allowed && candidate.type() == cricket::RELAY_PORT_TYPE)
     return;
 
   if (channel_) {
+    channel_->SetRemoteIceCredentials(candidate.username(),
+                                      candidate.password());
     channel_->OnCandidate(candidate);
   } else {
     pending_candidates_.push_back(candidate);
   }
 }
 
 const std::string& LibjingleTransport::name() const {
   DCHECK(CalledOnValidThread());
   return name_;
 }
@@ skipping 173 matching lines @@
     last_jingle_info_update_time_ = base::TimeTicks::Now();
 
   while (!on_jingle_info_callbacks_.empty()) {
     on_jingle_info_callbacks_.begin()->Run();
     on_jingle_info_callbacks_.pop_front();
   }
 }
 
 }  // namespace protocol
 }  // namespace remoting