Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: sky/engine/core/rendering/RenderText.cpp

Issue 1070233002: Remove dead code around anonymous renderers. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderText.cpp
diff --git a/sky/engine/core/rendering/RenderText.cpp b/sky/engine/core/rendering/RenderText.cpp
index 615a2e9c5f22f45b01003611cf99d22280c78662..d35c8f8e28e0b81c97219a893c2f0aabc21efe35 100644
--- a/sky/engine/core/rendering/RenderText.cpp
+++ b/sky/engine/core/rendering/RenderText.cpp
@@ -64,7 +64,7 @@ struct SameSizeAsRenderText : public RenderObject {
COMPILE_ASSERT(sizeof(RenderText) == sizeof(SameSizeAsRenderText), RenderText_should_stay_small);
RenderText::RenderText(Node* node, PassRefPtr<StringImpl> str)
- : RenderObject(!node || node->isDocumentNode() ? 0 : node)
+ : RenderObject(node)
, m_hasTab(false)
, m_linesDirty(false)
, m_containsReversedText(false)
@@ -78,10 +78,7 @@ RenderText::RenderText(Node* node, PassRefPtr<StringImpl> str)
, m_lastTextBox(0)
{
ASSERT(m_text);
- // FIXME: Some clients of RenderText (and subclasses) pass Document as node to create anonymous renderer.
- // They should be switched to passing null and using setDocumentForAnonymous.
- if (node && node->isDocumentNode())
- setDocumentForAnonymous(toDocument(node));
+ ASSERT(node && !node->isDocumentNode());
m_isAllASCII = m_text.containsOnlyASCII();
m_canUseSimpleFontCodePath = computeCanUseSimpleFontCodePath();
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698