Disable ability to show passwords when running in Metro.

chrome/browser/resources/options/password_manager_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.passwordManager', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var List = cr.ui.List;
 
@@ skipping 255 matching lines @@
           'profile.password_manager_allow_show_passwords',
           this.onPreferenceChanged_.bind(this));
     },
 
     /**
      * Listener for changes on the preference.
      * @param {Event} event The preference update event.
      * @private
      */
     onPreferenceChanged_: function(event) {
       this.showPasswords_ = event.value.value;

[Patrick Dubroy, 2013/12/13 16:54:01]

I think you want to change this to:

  if (this.showPasswords_) {
    this.showPasswords_ = event.value.value;
    this.redraw();
  }

That is, the pref should only be obeyed if disableShowPasswords was not set.

onPreferenceChanged_() will be called after showPasswords_ is initialized, which
probably explains why it didn't work when you did it in the initialization
before.

       this.redraw();
     },
 
     /** @override */
     createItem: function(entry) {
-      return new PasswordListItem(this.dataModel, entry, this.showPasswords_);
+      var showPasswords = this.showPasswords_;
+
+      if (loadTimeData.getBoolean('disableShowPasswords'))

[Patrick Dubroy, 2013/12/13 14:19:10]

Can't you just initialize this.showPasswords_ with this value?

+        showPasswords = false;
+
+      return new PasswordListItem(this.dataModel, entry, showPasswords);
     },
 
     /** @override */
     deleteItemAtIndex: function(index) {
       var item = this.dataModel.item(index);
       if (item && item.length > 3) {
         // The fourth element, if present, is the original index to delete.
         index = item[3];
       }
       PasswordManager.removeSavedPassword(index);
@@ skipping 35 matching lines @@
     },
   };
 
   return {
     PasswordListItem: PasswordListItem,
     PasswordExceptionsListItem: PasswordExceptionsListItem,
     PasswordsList: PasswordsList,
     PasswordExceptionsList: PasswordExceptionsList,
   };
 });