ui/gfx/render_text_harfbuzz.h - Issue 1070223004: Stop combining text runs which are connected by 'COMMON' blocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 1070223004: Stop combining text runs which are connected by 'COMMON' blocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure multiline breaker behavior is correct. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_harfbuzz.h

diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h

index 6d8fa8d962a13e7067e0d2f759cf8f9dbdb89916..1f6da9f87f58b569c49e8493a349ef1556254762 100644

--- a/ui/gfx/render_text_harfbuzz.h

+++ b/ui/gfx/render_text_harfbuzz.h

@@ -168,6 +168,7 @@ class GFX_EXPORT RenderTextHarfBuzz : public RenderText {

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_HorizontalAlignment);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_NormalWidth);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_WordWrapBehavior);

+ FRIEND_TEST_ALL_PREFIXES(RenderTextTest, Multiline_LineBreakerBehavior);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_RunDirection);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_HorizontalPositions);

FRIEND_TEST_ALL_PREFIXES(RenderTextTest,

« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_harfbuzz.cc » ('j') | ui/gfx/render_text_harfbuzz.cc » ('J')