[Webapp Refactor] Remove remoting.js.

remoting/webapp/crd/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 39 matching lines @@
   /** @private */
   this.hasReceivedFrame_ = false;
   this.logToServer = new remoting.LogToServer(signalStrategy);
 
   /** @private */
   this.signalStrategy_ = signalStrategy;
   base.debug.assert(this.signalStrategy_.getState() ==
                     remoting.SignalStrategy.State.CONNECTED);
   this.signalStrategy_.setIncomingStanzaCallback(
       this.onIncomingMessage_.bind(this));
-  remoting.formatIq.setJids(this.signalStrategy_.getJid(), host.jabberId);
+
+  /** @private */
+  this.iqFormatter_ = new remoting.FormatIq();

[kelvinp, 2015/04/16 18:13:01]

instead of the global remoting.formatIq

+  this.iqFormatter_.setJids(this.signalStrategy_.getJid(), host.jabberId);

[Jamie, 2015/04/16 20:15:29]

Move these to ctor parameters now that the object is recreated for each
connection?

 
   /**
    * Allow host-offline error reporting to be suppressed in situations where it
    * would not be useful, for example, when using a cached host JID.
    *
    * @type {boolean} @private
    */
   this.logHostOfflineErrors_ = true;
 
   /** @private {remoting.ClientPlugin} */
@@ skipping 288 matching lines @@
   var parser = new DOMParser();
   var iqNode = parser.parseFromString(message, 'text/xml').firstChild;
   var jingleNode = iqNode.firstChild;
   if (jingleNode) {
     var action = jingleNode.getAttribute('action');
     if (jingleNode.nodeName == 'jingle' && action == 'session-initiate') {
       this.sessionId_ = jingleNode.getAttribute('sid');
     }
   }
 
-  console.log(remoting.timestamp(), remoting.formatIq.prettifySendIq(message));
+  console.log(base.timestamp(), this.iqFormatter_.prettifySendIq(message));
   if (this.signalStrategy_.getState() !=
       remoting.SignalStrategy.State.CONNECTED) {
     console.log("Message above is dropped because signaling is not connected.");
     return;
   }
 
   this.signalStrategy_.sendMessage(message);
 };
 
 /**
@@ skipping 12 matching lines @@
 
 /**
  * @param {Element} message
  * @private
  */
 remoting.ClientSession.prototype.onIncomingMessage_ = function(message) {
   if (!this.plugin_) {
     return;
   }
   var formatted = new XMLSerializer().serializeToString(message);
-  console.log(remoting.timestamp(),
-              remoting.formatIq.prettifyReceiveIq(formatted));
+  console.log(base.timestamp(), this.iqFormatter_.prettifyReceiveIq(formatted));

[Jamie, 2015/04/16 20:15:29]

Unrelated to your change, but can this be restructured to use string
concatenation instead of multiple parameters? Chrome echoes only the first
parameter to stdout, so a single parameter is preferred (it makes debugging
browser tests easier, for example).

[kelvinp, 2015/04/16 21:18:37]

Done.

   this.plugin_.onIncomingIq(formatted);
 };
 
 /**
  * Callback that the plugin invokes to indicate that the connection
  * status has changed.
  *
  * @param {remoting.ClientSession.State} status The plugin's status.
  * @param {remoting.ClientSession.ConnectionError} error The plugin's error
  *        state, if any.
@@ skipping 150 matching lines @@
  * For example, if attempting a connection using a cached JID, host-offline
  * errors should not be logged because the JID will be refreshed and the
  * connection retried.
  *
  * @param {boolean} enable True to log host-offline errors; false to suppress.
  */
 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
   this.logHostOfflineErrors_ = enable;
 };