[Webapp Refactor] Remove remoting.js.

[Webapp Refactor] Remove remoting.js.

This CL cleanups the globals in remoting.js and removes the file itself.
Summary of changes:
1. remoting.getExtensionInfo() -> Application.getExtenstionInfo()
2. remoting.timestamp() -> base.timeStamp()
   I also simplified the implementation with Date.getISOString() instead of
   a custom formatter.
3. remoting.initGlobalObjects() -> Application.initGlobalObjects_()
4. remoting.formatIq -> ClientSession.iqFormatter_

BUG=477119
Committed: https://crrev.com/cf44a11dfcb30a7ea7f9a5bec7306ff7bb25db53
Cr-Commit-Position: refs/heads/master@{#325580}

[kelvinp, 2015-04-16 18:07:54]

Patchset #1 (id:1) has been deleted

[kelvinp, 2015-04-16 18:10:45]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-04-16 18:13:01]

PTAL

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/application.js (right):

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/application.js:108:
remoting.Application.prototype.initGlobalObjects_ = function() {
previously remoting.initGlobalObjects()

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/application.js:132:
remoting.Application.prototype.getExtensionInfo = function() {
previously remoting.getExtensionInfo()

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/base/js...
File remoting/webapp/base/js/base.js (right):

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/base/js...
remoting/webapp/base/js/base.js:756: return '[' + new Date().toISOString() +
']';
Use standard formatting instead of custom formatting

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_session.js (right):

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:62: this.iqFormatter_ = new
remoting.FormatIq();
instead of the global remoting.formatIq

[Jamie, 2015-04-16 20:15:30]

LFGTM!

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_session.js (right):

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:63:
this.iqFormatter_.setJids(this.signalStrategy_.getJid(), host.jabberId);
Move these to ctor parameters now that the object is recreated for each
connection?

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:405: console.log(base.timestamp(),
this.iqFormatter_.prettifyReceiveIq(formatted));
Unrelated to your change, but can this be restructured to use string
concatenation instead of multiple parameters? Chrome echoes only the first
parameter to stdout, so a single parameter is preferred (it makes debugging
browser tests easier, for example).

[Jamie, 2015-04-16 20:16:00]

Awww, I thought that acronym also worked :(

LGTM.

[kelvinp, 2015-04-16 21:18:37]

FYI

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_session.js (right):

https://codereview.chromium.org/1070223003/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:405: console.log(base.timestamp(),
this.iqFormatter_.prettifyReceiveIq(formatted));
On 2015/04/16 20:15:29, Jamie wrote:
> Unrelated to your change, but can this be restructured to use string
> concatenation instead of multiple parameters? Chrome echoes only the first
> parameter to stdout, so a single parameter is preferred (it makes debugging
> browser tests easier, for example).

Done.

[kelvinp, 2015-04-16 21:45:10]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-04-16 21:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1070223003/#ps40001
(title: "Reviewer's feedback")

[commit-bot: I haz the power, 2015-04-16 21:46:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070223003/40001

[commit-bot: I haz the power, 2015-04-16 23:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 23:25:15]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kelvinp, 2015-04-16 23:26:48]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-04-16 23:27:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070223003/40001

[kelvinp, 2015-04-17 00:05:20]

The CQ bit was unchecked by kelvinp@chromium.org

[kelvinp, 2015-04-17 00:05:25]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-04-17 00:07:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1070223003/40001

[commit-bot: I haz the power, 2015-04-17 01:58:55]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-17 02:00:05]

Patchset 2 (id:??) landed as
https://crrev.com/cf44a11dfcb30a7ea7f9a5bec7306ff7bb25db53
Cr-Commit-Position: refs/heads/master@{#325580}