Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 10702036: Allow inlining of functions containing function literals. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Allow inlining of functions containing function literals. R=yangguo@chromium.org BUG=v8:1322 TEST=mjsunit/compiler/inline-literals Committed: http://code.google.com/p/v8/source/detail?r=13945

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/ast.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/inline-literals.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-06-29 11:02:56 UTC) #1
Yang
On 2012/06/29 11:02:56, Michael Starzinger wrote: does this still need a review?
8 years, 5 months ago (2012-07-05 11:30:26 UTC) #2
Michael Starzinger
Rebased. Added Sven as reviewer.
8 years, 4 months ago (2012-08-17 10:53:45 UTC) #3
Sven Panne
lgtm
8 years, 2 months ago (2012-10-16 09:06:54 UTC) #4
Michael Starzinger
7 years, 9 months ago (2013-03-14 14:29:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698