Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: pkg/analyzer/lib/source/package_map_resolver.dart

Issue 1070203002: Issue 23133. Fix for restoring 'package:' uris on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/source/package_map_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/package_map_resolver.dart
diff --git a/pkg/analyzer/lib/source/package_map_resolver.dart b/pkg/analyzer/lib/source/package_map_resolver.dart
index dac2bb579fec469d2a5985af0addc8a28111e090..82021ba34daf8a1cb167aa7c90e74f4ec45c2799 100644
--- a/pkg/analyzer/lib/source/package_map_resolver.dart
+++ b/pkg/analyzer/lib/source/package_map_resolver.dart
@@ -7,6 +7,7 @@ library source.package_map_resolver;
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/util/asserts.dart' as asserts;
+import 'package:path/path.dart' as pathos;
/**
* A [UriResolver] implementation for the `package:` scheme that uses a map of
@@ -83,12 +84,13 @@ class PackageMapUriResolver extends UriResolver {
for (int i = 0; i < pkgFolders.length; i++) {
Folder pkgFolder = pkgFolders[i];
String pkgFolderPath = pkgFolder.path;
- // TODO(paulberry): figure out the right thing to do for Windows.
if (pkgFolderPath.length > bestMatchLength &&
- sourcePath.startsWith(pkgFolderPath + '/')) {
+ sourcePath.startsWith(pkgFolderPath + pathos.context.separator)) {
String relPath = sourcePath.substring(pkgFolderPath.length + 1);
if (_isReversibleTranslation(pkgFolders, i, relPath)) {
- bestMatch = Uri.parse('$PACKAGE_SCHEME:$pkgName/$relPath');
+ List<String> relPathComponents = pathos.context.split(relPath);
+ String relUriPath = pathos.posix.joinAll(relPathComponents);
+ bestMatch = Uri.parse('$PACKAGE_SCHEME:$pkgName/$relUriPath');
bestMatchLength = pkgFolderPath.length;
}
}
« no previous file with comments | « no previous file | pkg/analyzer/test/source/package_map_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698